Closed Marcel-G closed 1 year ago
Patch coverage: 62.50%
and project coverage change: -0.02%
:warning:
Comparison is base (
2f7df93
) 61.80% compared to head (3b5f1fa
) 61.79%.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
@mxinden this remaining issues something you can help with?
should we port the fix from https://github.com/webrtc-rs/sctp-proto/pull/6 to here?
@rainliu yes, works like a charm!
Great. Could you please fix format/clippy warning?
Still clippy errors.Make sure you are using same or above cargo version in the GitHub actions.
Resolves #468
Currently the library does not properly implement the shutdown procedure for data channels closed by Chrome. In order for the data channel to fully close, it must receive a
OutgoingResetRequest
.This was an existing issue in pion which has since been resolved here https://github.com/pion/sctp/pull/238
Reproduction
Using the examples/data-channels Run the JS test for closing data channels: jsfiddle Note the RTCDataChannels never enter
closed
state.