search

webrtc-rs / webrtc

A pure Rust implementation of WebRTC
https://webrtc.rs
Apache License 2.0
4.08k stars 363 forks source link

Pre-release dependencies should always be pinned #488

Closed thomaseizinger closed 1 year ago

thomaseizinger commented 1 year ago

Cargo will automatically select a higher pre-release dependency by default if there is one available, yet those updates are allowed to make breaking changes.

Therefore, depending on pre-releases should always be done with a = requirement. The following line is faulty: https://github.com/webrtc-rs/webrtc/blob/713d86f666294d210c0be70ea9cf7a15232a2b75/dtls/Cargo.toml#L34

See https://github.com/libp2p/rust-libp2p/actions/runs/5997417963/job/16263769915?pr=4355 for a CI failures caused by this.

rainliu commented 1 year ago

https://github.com/webrtc-rs/webrtc/pull/492 should fix this