Closed yinshanyang closed 12 months ago
Attention: 5 lines
in your changes are missing coverage. Please review.
Comparison is base (
71157ba
) 61.56% compared to head (821cb5b
) 61.50%.:exclamation: Current head 821cb5b differs from pull request most recent head 324cde0. Consider uploading reports for the commit 324cde0 to get more accurate results
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Please fix clippy/fmt
Please fix clippy/fmt
Seems like the clippy/fmt errors made their way into master
before this pull request:
Downloaded pkg-config v0.3.27
Downloaded openssl-sys v0.9.93
Downloaded openssl-macros v0.1.1
Downloaded foreign-types v0.3.2
Downloaded vcpkg v0.2.15
Downloaded foreign-types-shared v0.1.1
Downloaded openssl v0.10.57
Downloaded openssl-src v300.1.5+3.1.3
Downloaded 8 crates (9.4 MB) in 1.60s (largest was `openssl-src` at 8.8 MB)
Compiling webrtc-util v0.8.0 (/Users/shanyang/Projects/sandbox-rtmp/webrtc/util)
Compiling openssl-src v300.1.5+3.1.3
Compiling pkg-config v0.3.27
Compiling vcpkg v0.2.15
Compiling openssl v0.10.57
Checking foreign-types-shared v0.1.1
Compiling openssl-macros v0.1.1
Checking sdp v0.6.0 (/Users/shanyang/Projects/sandbox-rtmp/webrtc/sdp)
Checking foreign-types v0.3.2
Checking signal v0.1.0 (/Users/shanyang/Projects/sandbox-rtmp/webrtc/examples/examples/signal)
Checking examples v0.5.0 (/Users/shanyang/Projects/sandbox-rtmp/webrtc/examples)
Checking webrtc-constraints v0.1.0 (/Users/shanyang/Projects/sandbox-rtmp/webrtc/constraints)
Compiling openssl-sys v0.9.93
Checking stun v0.5.0 (/Users/shanyang/Projects/sandbox-rtmp/webrtc/stun)
Checking webrtc-dtls v0.8.0 (/Users/shanyang/Projects/sandbox-rtmp/webrtc/dtls)
Checking rtp v0.9.0 (/Users/shanyang/Projects/sandbox-rtmp/webrtc/rtp)
Checking webrtc-mdns v0.6.0 (/Users/shanyang/Projects/sandbox-rtmp/webrtc/mdns)
Checking webrtc-sctp v0.9.0 (/Users/shanyang/Projects/sandbox-rtmp/webrtc/sctp)
Checking rtcp v0.10.0 (/Users/shanyang/Projects/sandbox-rtmp/webrtc/rtcp)
Checking turn v0.7.0 (/Users/shanyang/Projects/sandbox-rtmp/webrtc/turn)
Checking webrtc-media v0.7.0 (/Users/shanyang/Projects/sandbox-rtmp/webrtc/media)
Checking webrtc-data v0.8.0 (/Users/shanyang/Projects/sandbox-rtmp/webrtc/data)
Checking webrtc-ice v0.10.0 (/Users/shanyang/Projects/sandbox-rtmp/webrtc/ice)
Checking hub v0.1.0 (/Users/shanyang/Projects/sandbox-rtmp/webrtc/dtls/examples/hub)
error: use of deprecated method `chrono::DateTime::<Tz>::timestamp_nanos`: use `timestamp_nanos_opt()` instead
--> rtp/src/extension/abs_send_time_extension/abs_send_time_extension_test.rs:39:49
|
39 | .checked_add(Duration::from_nanos(t.timestamp_nanos() as u64))
| ^^^^^^^^^^^^^^^
|
= note: `-D deprecated` implied by `-D warnings`
error: use of deprecated method `chrono::DateTime::<Tz>::timestamp_nanos`: use `timestamp_nanos_opt()` instead
--> rtp/src/extension/abs_send_time_extension/abs_send_time_extension_test.rs:58:49
|
58 | .checked_add(Duration::from_nanos(t.timestamp_nanos() as u64))
| ^^^^^^^^^^^^^^^
error: use of deprecated method `chrono::DateTime::<Tz>::timestamp_nanos`: use `timestamp_nanos_opt()` instead
--> rtp/src/packetizer/packetizer_test.rs:44:49
|
44 | .checked_add(Duration::from_nanos(t.timestamp_nanos() as u64))
| ^^^^^^^^^^^^^^^
error: could not compile `rtp` (lib test) due to 3 previous errors
warning: build failed, waiting for other jobs to finish...
Should I attempt to fix the errors there? As a heads up, I have not looked into rtp
at all before.
Implement the changes in https://github.com/pion/webrtc/pull/2531 which fixes https://github.com/pion/webrtc/issues/2472.
In addition to Firefox, OBS 30.0 Beta 3 frequently produces payloads larger than 255 bytes, even at the lowest bitrate setting of 64 kbps.