fix understated `ipnet` version requirement

webrtc-rs / webrtc

A pure Rust implementation of WebRTC

https://webrtc.rs

Apache License 2.0

4.08k stars 363 forks source link

fix understated `ipnet` version requirement #521

Closed scottlamb closed 9 months ago

scottlamb commented 9 months ago

webrtc-util uses IpNet::with_netmask, which was introduced in version 2.6.0. If someone is using a Cargo.lock with an older version of ipnet, they'll get a compile error when introducing webrtc-util (or upgrading it to after this call was added). Adding the correct version requirement in Cargo.toml forces the upgrade to fix this.

codecov[bot] commented 9 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (23d2e60) 61.52% compared to head (00787ad) 61.53%.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## master #521 +/- ## ======================================= Coverage 61.52% 61.53% ======================================= Files 529 529 Lines 48855 48859 +4 Branches 12369 12381 +12 ======================================= + Hits 30060 30063 +3 + Misses 9589 9587 -2 - Partials 9206 9209 +3 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.