Closed a-wing closed 5 months ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 61.70%. Comparing base (
a97d49e
) to head (6ae4033
). Report is 4 commits behind head on master.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
please fix formatting
@rainliu, can you comment on why https://github.com/webrtc-rs/webrtc/commit/935283abc719b2c3a6925cd8bb90ffb3809bccc5 changed the padding in the first place? I'm not sure I understand the reasoning and this was particularly hard to track down. Thank you!
dtls dependent crates upgrade to new version, however, incorrect usage of new APIs of those crates causes incompatible PADDING.
aes = "0.8" cbc = { version = "0.1", features = [ "block-padding", "alloc"] } ccm = "0.5"
I see, but how is PKCS7 relevant to DTLS? Does the RFC say somewhere that the padding schemes are equivalent?
We found use OBS-studio WHIP cannot PeerConnected
package DTLS have problem
We found after this commit have this bug
This PR https://github.com/webrtc-rs/webrtc/pull/496 and this commit after https://github.com/webrtc-rs/webrtc/pull/496/commits/935283abc719b2c3a6925cd8bb90ffb3809bccc5
Finally we found the problem. But, I'm not sure this have bug
https://github.com/RustCrypto/utils/blob/master/block-padding/src/lib.rs#L176-L216
Maybe, webrtc-rs is using this library incorrectly
https://github.com/binbat/live777/issues/39 https://github.com/binbat/live777/issues/58