Closed KillingSpark closed 2 months ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 61.50%. Comparing base (
dcfefd7
) to head (14f02f5
).
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
please fix cargo fmt check
The crc crate has released finally released a new version featuring an improved algorithm that greatly increases performance. The new algorithm uses a few Kb more of lookup tables which is why it has to be enabled explicitly. This PR bumps the version of the crc crate to the required level and enables that new algorithm.
Crc performance is a significant bottleneck in the sctp throughput as showcased by the throughput example:
Before:
After:
Edit: About the formatting CI: I can only reproduce one of the two fixes locally, but that one isn't related to this PR. The one related to this PR I can't reproduce locally (cargo fmt just doesn't produce this output for me...?!)
Do you want me to fix these two? I'd be glad to do it but I don't want to clutter the PR either