search

webrtc-rs / webrtc

A pure Rust implementation of WebRTC
https://webrtc.rs
Apache License 2.0
3.95k stars 347 forks source link

add hevc codec, along with a example for demonstration #579

Closed shiqifeng2000 closed 4 weeks ago

shiqifeng2000 commented 1 month ago

hi

I have added hevc codec/payloader, including an example for demonstration

rainliu commented 1 month ago

Thanks @shiqifeng2000 for adding hevc payloader. Could you fix clippy/fmt issue?

codecov[bot] commented 1 month ago

Codecov Report

Attention: Patch coverage is 0% with 347 lines in your changes missing coverage. Please review.

Project coverage is 61.14%. Comparing base (557186f) to head (cd87159).

Files Patch % Lines
...xamples/play-from-disk-hevc/play-from-disk-hevc.rs 0.00% 345 Missing :warning:
webrtc/src/rtp_transceiver/rtp_codec.rs 0.00% 1 Missing and 1 partial :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #579 +/- ## ========================================== - Coverage 61.58% 61.14% -0.44% ========================================== Files 532 533 +1 Lines 48969 49316 +347 Branches 12408 12507 +99 ========================================== - Hits 30158 30156 -2 - Misses 9583 9928 +345 - Partials 9228 9232 +4 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

shiqifeng2000 commented 1 month ago

Thanks @shiqifeng2000 for adding hevc payloader. Could you fix clippy/fmt issue?

you are welcome, just fixed, by the way, I ignore the DONL when emitting the rtp packet, since I believe it's up to sender/receiver to decide, let me know if you would like to support that