webrtc-rs / webrtc

A pure Rust implementation of WebRTC
https://webrtc.rs
Apache License 2.0
3.95k stars 347 forks source link

peer_connection: sdp: Fix BUNDLE group matching #583

Closed haaspors closed 3 weeks ago

haaspors commented 3 weeks ago

A minor bug in my last PR allowed an empty BUNDLE group attribute from offer to add all unmatched results into answer. The correct answer should not have any BUNDLE group either of course.

codecov[bot] commented 3 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 61.36%. Comparing base (89285ce) to head (6c48421).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #583 +/- ## ========================================== - Coverage 61.40% 61.36% -0.04% ========================================== Files 533 533 Lines 49678 49679 +1 Branches 12619 12618 -1 ========================================== - Hits 30505 30487 -18 + Misses 9855 9853 -2 - Partials 9318 9339 +21 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.