search

webrtc-rs / webrtc

A pure Rust implementation of WebRTC
https://webrtc.rs
Apache License 2.0
3.95k stars 347 forks source link

Remove `RTCIceCredentialType` #584

Closed Serial-ATA closed 2 weeks ago

Serial-ATA commented 3 weeks ago

The enum no longer exists in the spec: https://github.com/w3c/webrtc-pc/commit/0cba1631c58716d0f865639ab3b574da9497dbb5 https://developer.mozilla.org/en-US/docs/Web/API/RTCPeerConnection/RTCPeerConnection#credentialtype (marked deprecated)

rainliu commented 2 weeks ago

please fix check failures. Thanks.

Serial-ATA commented 2 weeks ago

Fixed, file didn't get pushed for some reason. Thanks

codecov[bot] commented 2 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 61.37%. Comparing base (a74b96d) to head (e483be5).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #584 +/- ## ========================================== - Coverage 61.38% 61.37% -0.01% ========================================== Files 533 532 -1 Lines 49711 49694 -17 Branches 12628 12623 -5 ========================================== - Hits 30513 30501 -12 + Misses 9856 9853 -3 + Partials 9342 9340 -2 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.