webrtc-sdk / libwebrtc

A C++ wrapper for binary release, mainly used for flutter-webrtc desktop (windows, linux, embedded).
MIT License
382 stars 78 forks source link

use raw pointer to uint8_t memory instead of custom "portable" string… #21

Closed pwinter1991 closed 2 years ago

pwinter1991 commented 2 years ago

Related to https://github.com/flutter-webrtc/flutter-webrtc/issues/908 the current implementation does not handle binary data correctly if it contains zero or "null" bytes as the string class that is used in the interface doesn't care for this type of data and shouldn't care for that.

I replaced the interface with a raw pointer instead of e.g. a std::vector to avoid dll boundary issues.

cloudwebrtc commented 2 years ago

LGTM