Open Lazarus404 opened 4 years ago
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).
:memo: Please visit https://cla.developers.google.com/ to sign.
Once you've signed (or fixed any issues), please reply here with @googlebot I signed it!
and we'll verify it.
ℹ️ Googlers: Go here for more info.
@googlebot I signed it!
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.
. If the bot doesn't comment, it means it doesn't think anything has changed.
ℹ️ Googlers: Go here for more info.
@googlebot I fixed it.
@googlebot I fixed it.
@googlebot I fixed it.
Dagnabbit @googlebot!
@googlebot https://github.com/googlebot I fixed it.
On 7 Jul 2020, at 19:21, googlebot notifications@github.com wrote:
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here https://cla.developers.google.com/ to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.
ℹ️ Googlers: Go here https://goto.google.com/prinfo/https%3A%2F%2Fgithub.com%2Fwebrtc%2FKITE%2Fpull%2F145 for more info.
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/webrtc/KITE/pull/145#issuecomment-655040465, or unsubscribe https://github.com/notifications/unsubscribe-auth/AACMMTCUI6S3KE7EXNFEUMLR2NRUNANCNFSM4OTGNHRQ.
I checked out your repository and used the command you gave above, got some error though. I'm using docker on Windows and not Linux, should that be a problem?
Yes, that will be the problem. You can create Linux Docker images on Linux and Macs, but on Windows, you can only create Windows images. It’s due to containers using the underlying host engine.
hmm, I thought it was only that you cannot run Linux docker on Windows. Anyway, I tried on Linux, the grid didn't seem to get launched. I updated kite-common with your PR as well.
Am I missing something?
The grid failed for some reason. Now that the library has been updated, I will create a fresh install, today, and see if I can reproduce.
All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.
We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent.
in this pull request.
Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla
label to yes
(if enabled on your project).
ℹ️ Googlers: Go here for more info.
This PR has been updated. Tests should now run.
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.
. If the bot doesn't comment, it means it doesn't think anything has changed.
ℹ️ Googlers: Go here for more info.
This PR needs an updated
kite-common
to work.To use, build the image passing in the args for the test directory name and config file name:
Then launch the image like this: