webrtc / KITE

KITE is a test engine designed to test WebRTC interoperability across browsers
Apache License 2.0
464 stars 125 forks source link

all the Mac scripts need to be updated for catalina and above (big sur #166

Closed agouaillard-cosmo closed 3 years ago

agouaillard-cosmo commented 3 years ago

The default shell is not bash, it s zsh .... https://carlosroso.com/the-right-way-to-migrate-your-bash-profile-to-zsh/

namvuCosmo commented 3 years ago

do the scripts not work? or is it just a good-to-have modification.

I tried the configureMac script on Big Sur, there was some text displaying glitch to be sorted out but overall the script still works.

agouaillard-cosmo commented 3 years ago

It did not work for me because the KITE_HOME variable was not set (it was set in .bashrc which is not read by new shell windows upon opening). Defining this variable in .Zhenv did the trick

Sent from my iPhone

On 15 Dec 2020, at 09:50, Nam notifications@github.com wrote:

 do the scripts not work? or is it just a good-to-have modification.

I tried the configureMac script on Big Sur, there was some text displaying glitch to be sorted out but overall the script still works.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or unsubscribe.

namvuCosmo commented 3 years ago

I'll try with a completely fresh install factory reset mac on big sur. Since the existing script works most of the time and some other times doesn't, there's no guarantee that changing it to zsh will work 100% of the times either :thinking:

agouaillard-cosmo commented 3 years ago

Why not simply writing the env variables in both files (.bashrc and .zhenv) so it would always work?

Sent from my iPhone

On 15 Dec 2020, at 14:09, Nam notifications@github.com wrote:

 I'll try with a completely fresh install factory reset mac on big sur. Since the existing script works most of the time and some other times doesn't, there's no guarantee that changing it to zsh will work 100% of the times either 🤔

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or unsubscribe.

namvuCosmo commented 3 years ago

added zshenv with https://github.com/webrtc/KITE/pull/169