search

webrtc / KITE

KITE is a test engine designed to test WebRTC interoperability across browsers
Apache License 2.0
468 stars 126 forks source link

security holding package #68

Closed DanielRuf closed 5 years ago

DanielRuf commented 5 years ago

Hi,

it seems you have accidentally added fs but this is not a package on npmjs, fs is an internal NodeJS module.

https://github.com/webrtc/KITE/search?q=0.1-security&unscoped_q=0.1-security

See https://nodejs.org/api/fs.html

You might want to remove it using npm uninstall fs.

namvuCosmo commented 5 years ago

Hi @DanielRuf ,

Thanks for pointing that out. We will look into it and update our code.

Please let us know if you find anything else that we can improve on.

namvuCosmo commented 5 years ago

fixed 5faa4ea2b005e0a2136d47b6ce0a02e9a315707a