Camera exposure example

webrtc / samples

WebRTC Web demos and samples

https://webrtc.github.io/samples

BSD 3-Clause "New" or "Revised" License

13.77k stars 5.69k forks source link

Camera exposure example #1533

Closed sjkummer closed 2 years ago

sjkummer commented 2 years ago

Description Added an example for exposure control based on getusermedia/ptz. Tested on Windows with Logitech Brio and C525 using official Logitech drivers.

Purpose

The support for exposure controls differs between cameras, platforms and drivers. It's nice to have an easy way to test it.
Keep @fippo busy 😉

google-cla[bot] commented 2 years ago

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

For more information, open the CLA check for this pull request.

fippo commented 2 years ago

The more samples the merrier!

eslint should be able to fix most errors on its own

sjkummer commented 2 years ago

eslint should be able to fix most errors on its own

eslint should be fine now

sjkummer commented 2 years ago

Seems like the chromedriver version is outdated in package.json: "chromedriver": "^98.0.1",

CI: Current browser version is 100.0.4896.75 with binary path browsers/bin/chrome-stable

Should I change that, or would you prefer to fix that in a separate PR? @fippo

fippo commented 2 years ago

that, along with some flakyness is fixed in #1534