search

webrtc / samples

WebRTC Web demos and samples
https://webrtc.github.io/samples
BSD 3-Clause "New" or "Revised" License
13.94k stars 5.71k forks source link

Allow `stuns:` URIs in the trickle ICE sample #1535

Closed rhansen closed 2 years ago

rhansen commented 2 years ago

The stuns URI scheme is defined in https://www.rfc-editor.org/rfc/rfc7064.html#section-3

fippo commented 2 years ago

iirc the reason we do the filtering and alerting manually is that we don't catch failures to construct the peerconnection - chrome throws when it encounters stuns:

rhansen commented 2 years ago

I pushed a commit to display the Chrome error.

fippo commented 2 years ago

thank you for splitting up the commits nicely too!