search

webrtc / samples

WebRTC Web demos and samples
https://webrtc.github.io/samples
BSD 3-Clause "New" or "Revised" License
13.77k stars 5.69k forks source link

permission: need to call resume() #1560

Open hakkisabah opened 2 years ago

hakkisabah commented 2 years ago

Description In this page : https://developer.chrome.com/blog/autoplay/#web-audio When we read the relevant page, we may need to make changes from the beginning, so we ask the user what to do before the AudioContext is called.

Purpose "The AudioContext was not allowed to start. It must be resumed (or created) after a user gesture on the page." It was not working because of this error, it has been fixed.

google-cla[bot] commented 2 years ago

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

alvestrand commented 2 years ago

The patch does not call resume(). Does it call something that calls resume()? If not, the title of the patch should be changed.