Make the gDM example request audio

webrtc / samples

WebRTC Web demos and samples

https://webrtc.github.io/samples

BSD 3-Clause "New" or "Revised" License

13.75k stars 5.69k forks source link

Make the gDM example request audio #1573

Closed eladalon1983 closed 1 year ago

eladalon1983 commented 1 year ago

As a Chromium committer, I use this page often to trigger gDM. I know many others who do the same. And we often need audio, which then requires us to use the DevTools console. Or worse, we interact with someone trying to reproduce an issue, and they report that "audio has now also stopped working" after interacting with this page.

fippo commented 1 year ago

i herewith delegate the 🍰 you owe for the review to @KaptenJansson

eladalon1983 commented 1 year ago

The cake is a lie.

fippo commented 1 year ago

But promises were made about different rules...

eladalon1983 commented 1 year ago

I am rejecting the Promise with an InvalidCharacterError.