WebGPU code refresh needed: layout parameter now required in createRenderPipeline calls

webrtc / samples

WebRTC Web demos and samples

https://webrtc.github.io/samples

BSD 3-Clause "New" or "Revised" License

13.94k stars 5.71k forks source link

WebGPU code refresh needed: layout parameter now required in createRenderPipeline calls #1602

Open tidoust opened 1 year ago

tidoust commented 1 year ago

The WebGPU specification (and implementation in Chrome) has evolved slightly since the samples were written. The layout parameter is now required when calling createRenderPipeline or createComputePipeline. Adding layout: 'auto' in calls to createRenderPipeline could be enough to fix that part (unless the code uses a more specific pipeline).

(That said, I think that some of the constructs in WGSL need updating too. I haven't tried to dig into that.)

fippo commented 1 year ago

@dogben ^

KubaGluszkiewicz commented 1 year ago

since chrome 114 there is more issues with this sample. I refactored code to make this sample working with newest chrome releases. Sadly i can't open PR here, so i'm attaching path if anyone interested 0001-refactored-code-to-be-compatible-with-newest-webgpu-.patch

@fippo fyi