webrtc / samples

WebRTC Web demos and samples
https://webrtc.github.io/samples
BSD 3-Clause "New" or "Revised" License
13.75k stars 5.69k forks source link

trickle-ice: support loading config from URL #1608

Closed stefansundin closed 4 months ago

stefansundin commented 1 year ago

Description

I want to help someone else debug on their network. It is hard to explain how to enter the configuration, username, etc. It would be simpler if I could just send a URL, ask them to open it, click the button, and take a screenshot of the result.

Putting the config in the hash prevents the browser from sending it to the server.

The URL for the default config would look like this: https://webrtc.github.io/samples/src/content/peerconnection/trickle-ice/#[{%22urls%22:[%22stun:stun.l.google.com:19302%22]}]

Purpose

Make it easier to send a config to someone else, for helping them test their network.

google-cla[bot] commented 1 year ago

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.