shimAddIceCandidateNullOrEmpty fails on Safari 17.0 - Githubissues

webrtcHacks / adapter

Shim to insulate apps from spec changes and prefix differences. Latest adapter.js release:

https://webrtcHacks.github.io/adapter/adapter-latest.js

BSD 3-Clause "New" or "Revised" License

3.63k stars 846 forks source link

shimAddIceCandidateNullOrEmpty fails on Safari 17.0 #1140

Open thewildtree opened 1 year ago

thewildtree commented 1 year ago

[x] I have provided steps to reproduce (e.g. a link to a jsfiddle)
[x] I have provided browser name, version and adapter.js version
[x] This issue only happens when adapter.js is used

Versions affected

Browser name including version (e.g. Chrome 64.0.3282.119)

Safari 17.0 (19616.1.27.111.16)

adapter.js (e.g. 6.1.0)

All versions >=8.0.0

Description

The shimAddIceCandidateNullOrEmpty step fails on Safari. This particular check breaks (len==0): https://github.com/webrtcHacks/adapter/blob/28c9f9471cb3df75cbb978c6f840e3315731790f/release/adapter.js#L1480-L1482

Causing this API to not be replaced correctly. This breaks the empty-candidate scenario, causing an error to be thrown.

Steps to reproduce

Insert https://webrtc.github.io/adapter/adapter-latest.js into your site (via Githubissues.
Githubissues is a development platform for aggregating issues.