webrtcHacks / adapter

Shim to insulate apps from spec changes and prefix differences. Latest adapter.js release:
https://webrtcHacks.github.io/adapter/adapter-latest.js
BSD 3-Clause "New" or "Revised" License
3.63k stars 845 forks source link

update test setup and bring back chai as a dependency #1147

Closed fippo closed 7 months ago

fippo commented 7 months ago

using chai@3.5.0 which is an older version that still works with karma-chai

fippo commented 7 months ago

@jan-ivar @pehrsons it seems FF Nightly rejects modifications to RTCSessionDescription.sdp. This has been tried in Chromium before and had to be pulled out. The test fix here is trivial but you may want to communicate this better than "we added a console warning" (which does not even have a bugzilla link)

https://webrtchacks.github.io/chromestatus/?buckets=1676,3451 shows data. This is ~1/3 of setRemoteDescription