search

websages / dashboards-bikeshed

BikeShed Dashboards
https://dashboard.thebikeshed.io
4 stars 2 forks source link

🚌 time off by an hour on planck #65

Open stephenyeargin opened 6 years ago

stephenyeargin commented 6 years ago

Betting it is a DST bug. Works on My Machineâ„¢, of course.

screen shot 2017-10-27 at 3 40 13 pm

Above screenshot taken at 3:40. Actual arrival is 3:55, not 4:55.

/cc @jameswhite

jameswhite commented 6 years ago

https://github.com/Shopify/dashing/issues/398

stephenyeargin commented 6 years ago

We used to bring in ActiveSupport to get some better timezone/DST handling, but that was stripped out to make the dashboards able to run on Flynn. Dunno if we bootstrap that back in, but wanted to note that this particular issue isn't :new:. It was broken before the countdown was introduced.

I had attempted to fix it with:

https://github.com/websages/dashboards-bikeshed/blob/87580521f77f671bd84388df7596d80667aaaa85/lib/nextbus.rb#L28-L34

That didn't fix it.

stephenyeargin commented 6 years ago

Definitely related to the time change, as it is currently working.