webscopeio / react-textarea-autocomplete

📝 React component implements configurable GitHub's like textarea autocomplete.

MIT License

454 stars 80 forks source link

New autocomplete behavior #107

Closed jukben closed 5 years ago

jukben commented 5 years ago

100 #101

This is the prototype of the new behavior which should solve the issues above.

I'd appreciate feedback from @guidogast

Example demoproject

jukben commented 5 years ago

(bot)

Hey! Thank you so much for your PR! I can see that everything is green 👏.

Here is the playground for this revision 🚀

I hope everything is fine! ❤️

guido-visser commented 5 years ago

Thanks for the work @jukben ! I'll take a look at it soon 😄

jukben commented 5 years ago

@guidogast Awesome. I've tuned a bit the CircleCI workflow, so now you can easily test the playground. 💃 The ( and . trigger should be your use case. But it would be awesome if you can confirm (so you probably need to checkout the repo anyway) that this behavior solves your issues. 👍

guido-visser commented 5 years ago

Hi @jukben I've played around a bit in the playground you provided. It seems to do exactly what I'd expect 👍 . I couldn't check the configuration though, but it all feels good when using it. Good work!

jukben commented 5 years ago

Awesome @guidogast, I'll deploy it soon as 4.0.0, so you can try it intercorporate it into your project and see in the real environment. 👍

Btw this is the configuration https://github.com/webscopeio/react-textarea-autocomplete/pull/107/files#diff-3b074cd8bf6b6c76fcedf7b209f844a8