search

webscopeio / react-textarea-autocomplete

📝 React component implements configurable GitHub's like textarea autocomplete.
MIT License
451 stars 80 forks source link

Escape key is not propagated when autocomplete is closed #116

Closed O4epegb closed 5 years ago

O4epegb commented 5 years ago

Escape key is not propagated when autocomplete is closed.

I think it might be because there is 2 listeners for Escape in Textarea.jsx and second one is never destroyed.

This one is probably unnecessary https://github.com/webscopeio/react-textarea-autocomplete/blob/master/src/Textarea.jsx#L254

O4epegb commented 5 years ago

If that is the case I might make a PR :)

jukben commented 5 years ago

Oh, sorry - I did a wrong rebase, you are right, that one is unnecessary! Could you please push PR for it? 👍

O4epegb commented 5 years ago

Sure, going to make it!

jukben commented 5 years ago

Closed in #118. Thanks for that!