search

webscopeio / react-textarea-autocomplete

📝 React component implements configurable GitHub's like textarea autocomplete.
MIT License
451 stars 80 forks source link

Minified React error #185 #125

Closed jukben closed 5 years ago

jukben commented 5 years ago

Hey guys, do you know when you release your great fix ? A user of my app just told me that her page crashed and I just figured out that she had this in the console: bug_charlie

Do you confirm that it is on your side ? I'll just wait for the fix :)

Originally posted by @BenoKop in https://github.com/webscopeio/react-textarea-autocomplete/issues/124#issuecomment-458129724

jukben commented 5 years ago

Hey @BenoKop, what version are you using? This could be also because of possible recursion here https://github.com/webscopeio/react-textarea-autocomplete/commit/3f822ab91859cf192b155a2cf0cd359f0ae3d3e8 We're preparing a fix for that as a part of #124. In that case, I'd recommend you to downgrade to 4.0.0 in a meantime.

Is this error also platform/user specifics? Are you able to reproduce it on your machine with dev mode enabled?

benoitkopp commented 5 years ago

Hey @jukben ! I'm using the 4.1.0 version. In my case, I was able to reproduce the bug on dev mode only on Chrome.

What I get bug_textarea1 bug_textarea2

This is the extreme bottom of my page. I have a Textarea which the users can tag other users. It is only crashing when I start to write AFTER the marker (@) AND on the second line of my textarea. charlie_bot

In this case, if I continue to type, it will crash. Hope it helps !

jukben commented 5 years ago

I see, that's exactly the issue @andypearson going to address in his PR solving this bug and the behavior in general. So sorry about that, the best what you can do to prevent it is to downgrade to 4.0.0.

benoitkopp commented 5 years ago

No probem, it happens. I'll wait for the coming fix :)

jukben commented 5 years ago

Deployed as 4.2.3! 🚀

benoitkopp commented 5 years ago

Nice work ! Tried it and updated my app !

Thanks a lot.