search

webscopeio / react-textarea-autocomplete

📝 React component implements configurable GitHub's like textarea autocomplete.
MIT License
451 stars 80 forks source link

Fix listener index increment #136

Closed O4epegb closed 5 years ago

O4epegb commented 5 years ago

Fixes #135

I fixed index incrementing, also changed default index to 1, because otherwise comparisons like if (this.escListener) would not work with 0.

jukben commented 5 years ago

(bot)

Hey! Thank you so much for your PR! I can see that everything is green 👏.

Here is the playground for this revision 🚀

I hope everything is fine! ❤️

jukben commented 5 years ago

Awesome. That makes so much sense. In the future, we might refactor the whole piece of code. Right now it's sufficient I hope.

jukben commented 5 years ago

Deployed as 4.3.1 🚀