search

webscopeio / react-textarea-autocomplete

📝 React component implements configurable GitHub's like textarea autocomplete.
MIT License
454 stars 80 forks source link

append suggestions dropdown in body #149

Closed teilzeitgeist closed 5 years ago

teilzeitgeist commented 5 years ago

see https://github.com/webscopeio/react-textarea-autocomplete/issues/128

jukben commented 5 years ago

(bot)

Hey! Thank you so much for your PR! I can see that everything is green 👏.

Here is the playground for this revision 🚀

I hope everything is fine! ❤️

jukben commented 5 years ago

Awesome, to see that boundariesElement works still like a charm. I would probably introduce another property renderToBody which does what you have here, otherwise I'll fallback to the original solution. What do you think about it? Are you willing to introduce the changes?

thank you for raising this! 🚀

teilzeitgeist commented 5 years ago

Done 👍

jukben commented 5 years ago

Hey I'm testing https://1026-94480675-gh.circle-artifacts.com/0/example/index.html but it looks like left position is not updated correctly (for example when you typing). Are you able to confirm it? Otherwise, thank you so far for pushing this!

teilzeitgeist commented 5 years ago

Yeah ... my last change destroyed it 😅 The solution was simple: "+=" instead of "=+" 🤦‍♂

jukben commented 5 years ago

Awesome, could you please add it also into docs (https://github.com/webscopeio/react-textarea-autocomplete#props). Right after textAreaComponent should be fine. Last thing and we are done! Thanks for the dope contribution! 🚀