search

webscopeio / react-textarea-autocomplete

📝 React component implements configurable GitHub's like textarea autocomplete.
MIT License
451 stars 80 forks source link

Fix react-dom peerDep version #154

Closed O4epegb closed 5 years ago

O4epegb commented 5 years ago

Yarn shows warning when installing warning " > @webscopeio/react-textarea-autocomplete@4.4.0" has incorrect peer dependency "react-dom@16.6.0".

I believe version should be like this "react-dom@^16.6.0" to allow minor and patch versions too!)

jukben commented 5 years ago

(bot)

Hey! Thank you so much for your PR! I can see that everything is green 👏.

Here is the playground for this revision 🚀

I hope everything is fine! ❤️

jukben commented 5 years ago

Hmm, that's good catch, I'm wondering why it's not just ^16.0.0. 🤔

EDIT: It's because https://github.com/webscopeio/react-textarea-autocomplete/commit/bb28cae7abaf197f619c782f6fdfbce438b77091 we are using Portals now. I think it makes sense to change it to ^16.0.0, what do you think? 🙏

O4epegb commented 5 years ago

Sure, even better! I thought that Portals were added in 16.6, but in fact they were in 16.0 already, so this should be fine!