search

webscopeio / react-textarea-autocomplete

đź“ť React component implements configurable GitHub's like textarea autocomplete.
MIT License
454 stars 80 forks source link

Add support for v18 of react and react-dom #236

Closed BillGeoghegan closed 2 years ago

BillGeoghegan commented 2 years ago

I wanted to update a project to use v18 of React and noticed this issue.

I've only updated the expected peer dependency of react and react-dom to allow v18, but if other maintainers would like me to bump the actual dependency (and edit the example index for new createRoot syntax) as well, I'm more than happy to do so. In my local testing with react and react-dom v18.2.0, this worked the same as before. Thanks!

CLAassistant commented 2 years ago

CLA assistant check
All committers have signed the CLA.

jukben commented 2 years ago

Thanks for the contribution! Let's merge it – regarding additional changes I'd rewrite it completely see https://github.com/webscopeio/react-textarea-autocomplete/issues/226