webscopeio / react-textarea-autocomplete

📝 React component implements configurable GitHub's like textarea autocomplete.
MIT License
454 stars 80 forks source link

Export flow-types to types.js #27

Closed danilowoz closed 7 years ago

danilowoz commented 7 years ago

Hi @jukben, #26 is done!

I just don't understand why you need the types into the /dist, because the build doesn't have flow.

I await your review 😄

jukben commented 7 years ago

I just don't understand why you need the types into the /dist, because the build doesn't have flow.

Yeah, that's right, but you still can type for example object which you pass the RTA.

Anyway I was thinking and I propose that we should copy entire src folder into dist/es6, then we could push to NPM only the dist folder and user could decide which version he wants to use. What do you think? @danilowoz

jukben commented 7 years ago

Hi @danilowoz do you want to finish this up, or it's free and I could assign it to someone else? I've pushed a huge PR enhancing dev experience, yarn dev for local development, Cypress.io for E2E, so you have to make a huge rebase, but basically what I need is the types.js which should be easy.

danilowoz commented 7 years ago

I think you can assign someone, no problem 😄 Good luck!

jukben commented 7 years ago

OK, at least you tried, thanks anyway 😆

meme