search

websdotcom / constant_contact

Activeresource wrapper gem for the Constant Contact API
MIT License
23 stars 22 forks source link

Campaign object modifications / fixes #7

Closed alandsidel closed 13 years ago

alandsidel commented 13 years ago

Hey there,

I've been using this gem for list management and recently wanted to use it to create email campaigns as well. This wasn't working as the XML being generated was bad, due to the to_xml() method creating tags for all the hash keys.

The changes are small, just the one main change and then a little bit of normalization/cleanup. The change to to_xml() was basically copied from contact.rb.

idris commented 13 years ago

Thanks for the patch! I think this warrants a version change from 1.3.3 to 1.4.0, since there are some changes in the API. What do you think?

alandsidel commented 13 years ago

No harm at all in raising it, I say go for it.