(Bug): "$this is not defined" message when there isn't any chosen select present in DOM

websemantics / Image-Select

Image Select is an extension of Chosen, a jQuery plugin that makes long, unwieldy select boxes much more user-friendly. It provides image support for Single and Multi select HTML tags.

http://websemantics.github.io/Image-Select

MIT License

147 stars 43 forks source link

(Bug): "$this is not defined" message when there isn't any chosen select present in DOM #14

Closed edu791 closed 9 years ago

edu791 commented 9 years ago

These are the two scenarios:

1) - Jquery Chosen loaded

ImageSelect loaded
There is at least one chosen select at DOM

result: OK. No problem

2) - Jquery Chosen loaded

ImageSelect loaded
There ISN'T any chosen select at DOM

result: Javascript error: "$this is not defined (line 167)"

krydos commented 9 years ago

@edwardoyarzun thank you. Your fix is really working.

iamcal commented 9 years ago

I've submitted a patch for this in #18 which correctly triggers chosen:hiding_dropdown for all chosen instances, instead of just the last one found.

NickEngeldinger commented 9 years ago

Additional thanks for your fix @edwardoyarzun

websemantics commented 9 years ago

https://github.com/websemantics/Image-Select/commit/a37fdfb32b8e9e935c38ff07be357debb1ba3275