search

websemantics / masonry-plus

Extends the masonry plugin (Cascading grid layout library) by David DeSandro to filter and shuffle items
MIT License
6 stars 2 forks source link

Filtering Problem #1

Closed KhayyamNosrati closed 7 years ago

KhayyamNosrati commented 7 years ago

Hi, I used your plugin in my project, but it toggle sometimes. I mean if i click on a filter for second time, layout changes into inline vertically and multiple "data-filter"s doesn't work. May I know how to fix them? Thank You for your nice job.

websemantics commented 7 years ago

I'm not surprised, .. you're the first person who used it other than myself, Here's the project I am using the plugin in, http://websemantics.github.io/pyrocms-cheatsheet/ for an example use, Other than that, I would need an example, JSFiddle?, or a way to re-create the issue, And thank you for kind words and feedback,

KhayyamNosrati commented 7 years ago

Good to hear that.. thank you for the reply.. this is the example you wanted https://jsfiddle.net/KhayyamNosrati/e1dzq4op/ if you click on design tab and after a second re-click on it, it changes the layout and you would see the result.

Good Day :-)

On Sun, Sep 11, 2016 at 4:50 AM, Adnan M.Sagar, PhD < notifications@github.com> wrote:

I'm not surprised, .. you're the first person who used it other than myself, Here's the project I am using the plugin in, http://websemantics.github.io/pyrocms-cheatsheet/ for an example use, Other than that, I would need an example, JSFiddle?, or a way to re-create the issue, And thank you for kind words and feedback,

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/websemantics/masonry-plus/issues/1#issuecomment-246151564, or mute the thread https://github.com/notifications/unsubscribe-auth/AT1Fm36rW5k-5zPl0p9WQgCI8t8OwprQks5qozsxgaJpZM4J3VH1 .

websemantics commented 7 years ago

That was a though one, .. I had to debug the original plugin and finally found the problem,

I've overridden a function from the original plugin, measureColumns so it should work now, v1.0.1

Will try to connect with the original plugin authors so they get the issue fixed and I can then remove the extra code,

Thanks for the helpful code demo for the bug,

KhayyamNosrati commented 7 years ago

Appreciate your support.. Thank you very much I see you did a wonderful job again.. sure, I appreciate that. And Thank you again for debugging it.

Good Day :-)

On Wed, Sep 21, 2016 at 1:50 AM, Adnan M.Sagar, PhD < notifications@github.com> wrote:

Closed #1 https://github.com/websemantics/masonry-plus/issues/1.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/websemantics/masonry-plus/issues/1#event-796274488, or mute the thread https://github.com/notifications/unsubscribe-auth/AT1FmyccqsonfMW-Fq1LHCiG1Yur7zGjks5qsEAYgaJpZM4J3VH1 .