Update native-tls and tokio-tls

websockets-rs / rust-websocket

A WebSocket (RFC6455) library written in Rust

http://websockets-rs.github.io/rust-websocket/

MIT License

1.55k stars 223 forks source link

Update native-tls and tokio-tls #186

Closed mati865 closed 6 years ago

mati865 commented 6 years ago

Native-tls 0.1 uses outdated openssl crate that doesn't build with OpenSSL 1.1.1 (Arch Linux is already using it and openSUSE Tumbleweed will update in a few days). Updating native-tls also fixes few issues with static OpenSSL builds.

It throws warnings like:

warning: use of deprecated item 'tokio_io::AsyncRead::framed': Use tokio_codec::Decoder::framed instead
   --> src/server/upgrade/async.rs:221:5
    |
221 |             .framed(HttpServerCodec)
    |

But I couldn't manage to fix them.

vi commented 6 years ago

Which version should it be after this pull request: 0.20.4 or 0.21.0?

mati865 commented 6 years ago

Which version should it be after this pull request: 0.20.4 or 0.21.0?

It requires upgrading native-tls from 0.1 to 0.2 to work so I think it's breaking change.

mati865 commented 6 years ago

Ping

vi commented 6 years ago

I have a reminder to check accumulated pull requests and make a rust-websocket release in 20 days, in case of inactivity of original developers of rust-websocket.