Improve Display impl for WebSocketOtherError

websockets-rs / rust-websocket

A WebSocket (RFC6455) library written in Rust

http://websockets-rs.github.io/rust-websocket/

MIT License

1.55k stars 223 forks source link

Improve Display impl for WebSocketOtherError #249

Closed Enet4 closed 4 years ago

Enet4 commented 4 years ago

This PR provides a more informative error message when a WebSocketOtherError is displayed. The main driver of this change is vi/websocat#55, which would then indicate the concrete status code obtained from the server.

lovasoa commented 4 years ago

Is there anything preventing this from being merged ? It looks like several people are waiting for this in https://github.com/vi/websocat/issues/55

@vi

vi commented 4 years ago

Looks OK.

Maybe merge things and publish some releases soon (or "someday").