Remove deprecated usage of the "description" and "cause" functions

websockets-rs / rust-websocket

A WebSocket (RFC6455) library written in Rust

http://websockets-rs.github.io/rust-websocket/

MIT License

1.54k stars 222 forks source link

Remove deprecated usage of the "description" and "cause" functions #264

Closed Mr-Leshiy closed 2 years ago

Mr-Leshiy commented 2 years ago

Remove deprecated usage of the description function and replace it with to_string function. Remove deprecated usage of the cause function and replace it with source function.

vi commented 2 years ago

Do usages of the deprecated Error methods cause any real problems or just the annoying messages?

Mr-Leshiy commented 2 years ago

@vi , currently just annoying messages, but it is possible that they will be removed later.

vi commented 2 years ago

I expected the crate to be still edition=2015 (supporting legacy Rust versions), but now noticed that is edition=2018, so there versions below 1.31 are already unsupported. Since Error::source is 1.30, that shouldn't bump MSRV, so this can be merged.

vi commented 2 years ago

Published 0.26.3, but the project is still in "deprecated, avoid usage" mode.