Updates

[j-f1]

• switch to TypeScript
• make the CSS better match the default dictionary
• parse parts of speech and expand them (since we don’t have space constraints in an electronic dictionary)
  • I tried to piece these together by referencing the words that used the abbreviations and plugging the abbreviations into Wiktionary, but I’m not entirely confident with all of them so if you have some knowledge in this area I’d appreciate a once-over on that
• add a couple missing abbreviations
• add support for matrices (which are only used once or twice, but still)

I’m happy to revert some of the more dramatic changes (TypeScript and ES6-ification specifically) if you’d like.

[j-f1]

Also, a quick question: It looks like this repo is licensed under the GPL, but the package.json metadata says the license is ISC (which is like MIT). Which license do you intend to use?

[jeffbyrnes]

Can’t say about the licensing, but I do like this overall! I’m not well-versed in TypeScript, but I hear good things.

That said, it might be more beneficial to keep things simpler & not introduce TS? I’ll defer to @ponychicken as the maintainer for sure.

Also, #10 merged recently, so this needs a rebase.

[j-f1]

Getting this error in the lint script:

Error Error: Received status code 403
    at IncomingMessage.res.on (/action/lib/request.js:13:25)
    at IncomingMessage.emit (events.js:203:15)
    at endReadableNT (_stream_readable.js:1145:12)
    at process._tickCallback (internal/process/next_tick.js:63:19)
{"message":"Resource not accessible by integration","documentation_url":"https://developer.github.com/v3/checks/runs/#create-a-check-run"}

[ponychicken]

The lint thing needs some love: https://github.com/hallee/eslint-action Only recently added support for .ts files, and right now we are using v1.0 which doesnt include this patch. But the master branch is also broken :( I guess we either fork & fix it, or take it out.

[ponychicken]

I added the custom font to fix the display of the accents (see screenshot). But maybe there are also other ways to fix it without adding a large font...

[ponychicken]

But the adjective part looks really nice!

[jeffbyrnes]

I think we can pull out the automated linting for now.

[j-f1]

Weird, here’s what I’m seeing:

[jeffbyrnes]

I will say, for me, I’ve really enjoyed that the Webster’s formatting is different. I.e., the red serif typeface for the entry titles.

[j-f1]

I could try to add a setting in Dictionary preferences to switch the font.

Also, I tried to hide etymology from the dictionary popup you get by force clicking a word, but it seems to have stopped working.

[ponychicken]

Thanks – i merged most of you changes, except the CSS