MacOS Dictionary App Hangs Up While searching certain words

websterParser / WebsterParser

Convert Webster's Unabridged 1913 dictionary in to a more usable format

GNU General Public License v3.0

351 stars 20 forks source link

MacOS Dictionary App Hangs Up While searching certain words #56

Closed suhailasif closed 2 years ago

suhailasif commented 2 years ago

I have installed the webster's-1913.dictionary folder in MacOS's dictionary folder
The dictionary app Hangs up while searching certain words such as contrite, Love etc.
The app works fine for a better part of dictionary searches.
These words searched in other dictionaries installed in dictionary app return queries without hanging up.

Using MacOS Monterey, Intel Chip

jeffbyrnes commented 2 years ago

Can confirm it hangs for me, too, when searching “contrite” on my Mac. (latest Monterey, Intel chipset as well).

cratermoon commented 2 years ago

Same here. The words "synoptic", "student", and "store", for example, cause the dictionary to hang for a while, the cursor turns to the "spinning beachball of death", and it shows the entry for "stooge".

jeffbyrnes commented 2 years ago

I’ve poked at this a few times since first noticing it; it’s some sort of syntax error or conversion error, but unfortunately the format of the original source isn’t something I understand very well, so I don’t really know where to begin with debugging.

If anyone has any experience w/ GCIDE and the format they use, perhaps they can help?

Interestingly, these entries can be seen in the online version of GCIDE. Here’s “synoptic” for example.

cratermoon commented 2 years ago

I’ve poked at this a few times since first noticing it; it’s some sort of syntax error or conversion error, but unfortunately the format of the original source isn’t something I understand very well, so I don’t really know where to begin with debugging.

If anyone has any experience w/ GCIDE and the format they use, perhaps they can help?

Interestingly, these entries can be seen in the online version of GCIDE. Here’s “synoptic” for example.

I went back to the 1.3.4 release zip and installed that. It seems to work OK. The diff between 1.3.4 and 1.3.6 suggests some changes in index.ts might be a good place to start. Sorry I can't be more helpful, though.

jeffbyrnes commented 2 years ago

Thanks @cratermoon, that’s great to know. Clearly a regression of some sort was introduced. I’ll try to make some time to dig in & look, but having you narrow it down like that is a huge help!

dangduc commented 2 years ago

I went back to the 1.3.4 release zip and installed that. It seems to work OK. The diff between 1.3.4 and 1.3.6 suggests some changes in index.ts might be a good place to start. Sorry I can't be more helpful, though.

+1: Incrementally typing the letters to "structure" hangs the dictionary.app for me. Workaround was to switch to 1.3.4.

jeffbyrnes commented 2 years ago

Thanks for confirming that 1.3.5 & beyond are where this regression crept in. There were some pretty major refactors that happened in there so something must have come unstuck.

jeffbyrnes commented 2 years ago

I’m validating that #81 did the trick, and if so, I’ll cut a new release for y’all!

jeffbyrnes commented 2 years ago

Ok, new build with fixes from #81 fix this! I’ll publish a new .dictionary shortly.