search

websterclay / knife-github-cookbooks

A knife plugin facilitating installing, updating, and tracking Chef cookbooks found on Github.
Apache License 2.0
220 stars 35 forks source link

--branch option for vendor pattern is broken [upstream] #7

Closed ches closed 13 years ago

ches commented 13 years ago

This is not really a knife-github-cookbooks bug -- it's broken in knife core and knife-github-cookbooks suffers for it. I'm shamelessly filing it here in hopes that it increases visibility to others who are bothered by it and that more votes on the Jira ticket or comments on the pull request might get Opscode's attention, and additionally to make anyone who may stumble across it aware that it is not @websterclay's bug...

To summarize, the issue is that knife's vendor branch pattern magic automatically checks out master and merges into it when you install/update a cookbook. I want to test and add configuration and customizations after installing a cookbook, and merge when it's ready for production, so this is highly annoying. A --branch option was added to Knife to address this, but it was broken in the push to Chef 0.10.0.

ches commented 13 years ago

Doh, sorry, I just saw that this was mentioned and closed in #6 since I thought of filing this here awhile ago, and that you opened a new Jira ticket for it. Maybe we'll have some luck in getting it merged with CHEF-2105...

ches commented 13 years ago

This has been fixed upstream and released in Chef 0.10.4. Woot :-)