feat(tests): uses new @web/test-runner instead of karma #27

webtides / element-js

Simple and lightweight base classes for web components with a beautiful API

MIT License

28 stars 3 forks source link

feat(tests): uses new @web/test-runner instead of karma #27 #40

Closed quarkus closed 2 years ago

eddyloewen commented 2 years ago

@quarkus What about the karma.conf.js file? Is it still needed?

quarkus commented 2 years ago

@quarkus What about the karma.conf.js file? Is it still needed?

nope. removed

eddyloewen commented 2 years ago

Nice! But what is it with all the white space changes?! I don't get it! That was supposed to NOT happen... Has something changed?! Do we not use the git-hooks anymore?

quarkus commented 2 years ago

Nice! But what is it with all the white space changes?! I don't get it! That was supposed to NOT happen... Has something changed?! Do we not use the git-hooks anymore?

I think it was actually broken (not well formatted) before and got fixed now (by prettier / husky) cause i had to touch all the test files.

But i am pretty sure that our prettier config is broken as it inserts tabs instead of spaces ... and tabs is false by default. I´ll raise an issue for that ..