search

webtides / luna-js

MIT License
8 stars 0 forks source link

Feature/#73 use esm #114

Closed lukas-schardt closed 2 months ago

eddyloewen commented 2 years ago

I'm trying to use the new version in some of my recent projects. I'm still running into some errors...

This one for example:

"The component with the tag name "undefined" has no ElementFactory"

Also I had some trouble defining the factory. Would it be possible to set the factory by reference rather than just a string?

eddyloewen commented 2 years ago

I also tried to use this new version for the ocean-crm demo project. I'm running into some weird bugs. I'm not getting any error messages. The luna startup just stops before registering components and prints out a bunch of bundled code for one single imported file (but not all of it...) See: https://github.com/webtides/ocean-crm/tree/feature/type-module

eddyloewen commented 2 years ago

I'm trying to use the new version in some of my recent projects. I'm still running into some errors...

This one for example:

"The component with the tag name "undefined" has no ElementFactory"

Also I had some trouble defining the factory. Would it be possible to set the factory by reference rather than just a string?

If I add some more logging:

The component with the tag name "undefined" has no ElementFactory { component: { element: [class index], ElementFactory: undefined }, attributes: {} }

I think this is the index page?

Also the luna-renderer package is still "commonjs" and bundles a bunch of require stuff - is that supposed to be like that?

eddyloewen commented 2 months ago

@lukas-schardt @quarkus I think this should be good now! Please have a look 😆 I will update the changelog and write a small upgrade guide next week