search

webtjs / pe

0 stars 0 forks source link

Fled games in stats is not consistent between TicTacToe and Hangman #3

Open webtjs opened 5 months ago

webtjs commented 5 months ago

If the user quits during TicTacToe difficulty selection, it counts as fleeing whereas if the user quits during hangman category selection, it does not count as fleeing.

Quitting during hangman category selection

image.png

Quitting during TicTacToe difficulty selection

image.png

nus-pe-bot commented 5 months ago

Team's Response

Duplicated bug to #1955. Actions should be standardised and an improvement could be to abolish counting a "quit" when "quitting" in selection mode of game difficulty/category.

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

Incorrect number of times players have fled

image.png

When I quit during the choosing of the difficulty of the TTT game, that act of quitting is counted as 1. However, when I play hangman, and I quit whilst I am still at the stage of choosing the category, the number of times I have fled is not added by one.

[original: nus-cs2113-AY2324S2/pe-interim#1729] [original labels: type.FunctionalityBug severity.VeryLow]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

The action of what counted towards quitting during the difficulty/category selection mode was not well synchronised. Perhaps would be more logical to not add a count to quitting when calling 'quit' in the difficulty/category selection of TTT and hangman respectively.

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: [replace this with your explanation]

## :question: Issue type Team chose [`type.FunctionalityBug`] Originally [`type.FeatureFlaw`] - [ ] I disagree **Reason for disagreement:** [replace this with your explanation]
## :question: Issue severity Team chose [`severity.VeryLow`] Originally [`severity.Low`] - [x] I disagree **Reason for disagreement:** ![image.png](https://raw.githubusercontent.com/webtjs/pe/main/files/e85be668-02bb-4762-9b7e-e1f9ae98dad5.png) Based on the bug severity definitions provided on the CS2113 website, `severity.VeryLow` should only be used to describe cosmetic problems. However, with regards to what counts as a fled game for TicTacToe and Hangman, it is more of an issue with the logic of the code rather than just a cosmetic problem. The inconsistency between what counts as a fled game for TicTacToe and Hangman does not affect the normal operation of the program and only causes a minor inconvenience. Hence, `severity.Low` would be a better fit for this bug.