webtorrent / bittorrent-dht

🕸 Simple, robust, BitTorrent DHT implementation
https://webtorrent.io
MIT License
1.23k stars 203 forks source link

chore: switch to ESM #248

Closed king-11 closed 1 year ago

king-11 commented 2 years ago

What is the purpose of this pull request? (put an "X" next to item)

What changes did you make? (Give an overview)

Which issue (if any) does this pull request address?

Is there anything you'd like reviewers to focus on?

welcome[bot] commented 2 years ago

🙌 Thanks for opening this pull request! You're awesome.

king-11 commented 2 years ago

@feross @DiegoRBaquero any reviews on this one

king-11 commented 2 years ago

@DiegoRBaquero any update on this?

ThaUnknown commented 2 years ago

it's likely he doesnt have the time as of now, but might soon

If i was you i'd do these in batches of like 10 at a time tbh x)

king-11 commented 2 years ago

@ThaUnknown 😂 i did rather wait...can work on PRs for other repository by the time this one gets reviewed

ThaUnknown commented 2 years ago

@ThaUnknown 😂 i did rather wait...can work on PRs for other repository by the time this one gets reviewed

you definitely should, then the person reviewing these PR's can just sit down for 1-2h and do it all in a batch, rather than one at a time

DiegoRBaquero commented 2 years ago

Node modules should go first, then npm modules then local modules 🙏🏼

welcome[bot] commented 1 year ago

🎉 Congrats on getting your first pull request landed!

webtorrent-bot commented 1 year ago

:tada: This PR is included in version 10.0.7 :tada:

The release is available on:

Your semantic-release bot :package::rocket: