Closed king-11 closed 1 year ago
🙌 Thanks for opening this pull request! You're awesome.
@feross @DiegoRBaquero any reviews on this one
@DiegoRBaquero any update on this?
it's likely he doesnt have the time as of now, but might soon
If i was you i'd do these in batches of like 10 at a time tbh x)
@ThaUnknown 😂 i did rather wait...can work on PRs for other repository by the time this one gets reviewed
@ThaUnknown 😂 i did rather wait...can work on PRs for other repository by the time this one gets reviewed
you definitely should, then the person reviewing these PR's can just sit down for 1-2h and do it all in a batch, rather than one at a time
Node modules should go first, then npm modules then local modules 🙏🏼
🎉 Congrats on getting your first pull request landed!
:tada: This PR is included in version 10.0.7 :tada:
The release is available on:
Your semantic-release bot :package::rocket:
What is the purpose of this pull request? (put an "X" next to item)
What changes did you make? (Give an overview)
Which issue (if any) does this pull request address?
Is there anything you'd like reviewers to focus on?