webtorrent / bittorrent-protocol

Simple, robust, BitTorrent peer wire protocol implementation
https://webtorrent.io
MIT License
349 stars 71 forks source link

fix: return `this` from `destroy` and `end` #74

Closed danielroe closed 2 years ago

danielroe commented 2 years ago

What is the purpose of this pull request? (put an "X" next to item)

[ ] Documentation update [x] Bug fix [ ] New feature [ ] Other, please explain:

What changes did you make? (Give an overview)

For consistency with Node readable stream implementation, destroy() and end() should likely return this - https://nodejs.org/api/stream.html#readabledestroyerror

Context: https://github.com/DefinitelyTyped/DefinitelyTyped/pull/57473

welcome[bot] commented 2 years ago

🙌 Thanks for opening this pull request! You're awesome.

welcome[bot] commented 2 years ago

🎉 Congrats on getting your first pull request landed!

webtorrent-bot commented 2 years ago

:tada: This PR is included in version 3.4.5 :tada:

The release is available on:

Your semantic-release bot :package::rocket: