search

webtorrent / bittorrent-protocol

Simple, robust, BitTorrent peer wire protocol implementation
https://webtorrent.io
MIT License
349 stars 71 forks source link

fix: reject on error and activation guards for Fast Extension #79

Closed paullouisageneau closed 2 years ago

paullouisageneau commented 2 years ago

What is the purpose of this pull request? (put an "X" next to item)

[X] Documentation update [X] Bug fix [ ] New feature [ ] Other, please explain:

What changes did you make? (Give an overview)

This PR fixes the behavior on request error by automatically rejecting the request if Fast Extension is enabled. It also fixes activation guards for the extension and makes them consistent. I took the opportunity to add more tests and update the readme.

Which issue (if any) does this pull request address?

The original issue for Fast Extension is https://github.com/webtorrent/webtorrent/issues/1995.

Is there anything you'd like reviewers to focus on?

Nothing in particular.

webtorrent-bot commented 2 years ago

:tada: This PR is included in version 3.5.1 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

Amisha221 commented 2 years ago

Great