search

webtorrent / bittorrent-tracker

🌊 Simple, robust, BitTorrent tracker (client & server) implementation
https://webtorrent.io
MIT License
1.78k stars 319 forks source link

chore(git): add gitignore #361

Closed alxhotel closed 3 years ago

alxhotel commented 3 years ago

What is the purpose of this pull request? (put an "X" next to item)

[ ] Documentation update [ ] Bug fix [ ] New feature [X] Other, please explain:

What changes did you make? (Give an overview) Add missing .gitignore similar to other repositories

Which issue (if any) does this pull request address? None

Is there anything you'd like reviewers to focus on? None

DiegoRBaquero commented 3 years ago

Given that the tracker is also a standalone CLI app, I think we should have package-lock.

alxhotel commented 3 years ago

Yep, good point @DiegoRBaquero. I have updated the PR

feross commented 3 years ago

@DiegoRBaquero When people install the CLI app, don't they just use npm install bittorrent-tracker? The package-lock.json won't be used if they install from npm.

DiegoRBaquero commented 3 years ago

@DiegoRBaquero When people install the CLI app, don't they just use npm install bittorrent-tracker? The package-lock.json won't be used if they install from npm.

You are right, none of our module are apps where we run npm install, and now that we have pinned dev deps, doesn't makes sense to have it

DiegoRBaquero commented 3 years ago

:tada: This PR is included in version 9.17.1 :tada:

The release is available on:

Your semantic-release bot :package::rocket: