search

webtorrent / bittorrent-tracker

🌊 Simple, robust, BitTorrent tracker (client & server) implementation
https://webtorrent.io
MIT License
1.78k stars 319 forks source link

Define DEFAULT_ANNOUNCE_INTERVAL (line 15) #363

Closed ProgrammedThought closed 3 years ago

ProgrammedThought commented 3 years ago

Shouldn't DEFAULT_ANNOUNCE_INTERVAL be defined in the common.js file or in the constructor of Tracker? I can't find it anywhere in the other files as well. If this works some way that I can't see over here, I would be really grateful for a brief explanation.

What is the purpose of this pull request? (put an "X" next to item)

[ ] Documentation update [X] Bug fix [ ] New feature [ ] Other, please explain:

What changes did you make? (Give an overview) I just suggested a change to a potential bug.

Which issue (if any) does this pull request address? An undefined attribute of the class Tracker.

Is there anything you'd like reviewers to focus on?

welcome[bot] commented 3 years ago

🙌 Thanks for opening this pull request! You're awesome.