search

webtorrent / bittorrent-tracker

🌊 Simple, robust, BitTorrent tracker (client & server) implementation
https://webtorrent.io
MIT License
1.75k stars 317 forks source link

Brave Webtorrent buiild broken after bittorrent-tracker@9.18.0 #397

Closed yrliou closed 3 years ago

yrliou commented 3 years ago

As title, it seems https://github.com/webtorrent/bittorrent-tracker/pull/356/files#diff-7ae45ad102eab3b6d7e7896acd08c427a9b25b346470d7bc6507b6481575d519R21 introduces socks module and only set it to false in browser but not chromeapp, so Brave Webtorrent build is failed as below.

03:54:54  ERROR in ./node_modules/socks/lib/socks-client.js
03:54:54  Module not found: Error: Can't resolve 'net' in '/home/ubuntu/workspace/pr-brave-browser-fix-audit-8-31-linux/src/brave/node_modules/socks/lib'
03:54:54  ERROR in ./node_modules/socks/lib/socks-agent.js
03:54:54  Module not found: Error: Can't resolve 'tls' in '/home/ubuntu/workspace/pr-brave-browser-fix-audit-8-31-linux/src/brave/node_modules/socks/lib'

cc @feross

yrliou commented 3 years ago

Closed by https://github.com/webtorrent/bittorrent-tracker/pull/398