search

webtorrent / bittorrent-tracker

🌊 Simple, robust, BitTorrent tracker (client & server) implementation
https://webtorrent.io
MIT License
1.77k stars 317 forks source link

fix https://github.com/webtorrent/bittorrent-tracker/issues/424 #425

Closed zackees closed 2 years ago

zackees commented 2 years ago

What is the purpose of this pull request? (put an "X" next to item)

[ x] Documentation update [ ] Bug fix [ ] New feature [ ] Other, please explain:

What changes did you make? (Give an overview)

Update readme so that users looking to install a docker version of this app can be pointed to https://github.com/zackees/docker-bittorrent-tracker

Which issue (if any) does this pull request address?

Users can deploy bittorrent-tracker on the internet using docker.

Is there anything you'd like reviewers to focus on?

No functional changes in the codebase. This should be pretty straightforward.

welcome[bot] commented 2 years ago

🙌 Thanks for opening this pull request! You're awesome.

zackees commented 2 years ago

@DiegoRBaquero @watson @mvayngrib @feross @Flet @alxhotel

ThaUnknown commented 2 years ago

chill with the pings a bit, there are 15 PR's in queue before yours which also need to be reviewed

zackees commented 2 years ago

Thanks for your attention to my PR's. I want to say that I've been a fan of webtorrent for years but it's never worked for me. After weeks of work I've been able to get it to work and my hope is that I can contribute back these changes to the benefit of the team.

I tried to keep these PR's as small and as targeted as possible to address the common issues which appear to be causing problems for others trying to deploy Webtorrent. My intention was to have such simple PR's that all of them could be evaluated in 10 mins.

The common footguns I observe users are hitting include

  1. Deploying a webtorrent tracker
  2. Seeding content from the command line

The changes to the readme file on the bitorrent-tracker essentially solves (1), and I'm still working on solving (2).

Can you help me to get these in? Or would you recommend that I consider forking my code and releasing my own npm packages? I'm cool either way.

github-actions[bot] commented 2 years ago

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?