Closed ThaUnknown closed 8 months ago
Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?
this was abandoned, as native fetch doesn't have an agent parameter unlike node-fetch
👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎
This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.
New and removed dependencies detected. Learn more about Socket for GitHub ↗︎
Packages | Version | New capabilities | Transitives | Size | Publisher |
---|---|---|---|---|---|
undici | 5.27.0 | network, environment | +1 |
1.22 MB | ronag |
🚮 Removed packages: simple-get@4.0.1
this now works, but imports undici, for the socks agent, which I have mixed feelings on, maybe instead the socks agent should be provided by the users, same as http and https agent?
:tada: This PR is included in version 11.0.0 :tada:
The release is available on:
Your semantic-release bot :package::rocket:
What is the purpose of this pull request? (put an "X" next to item)
[ ] Documentation update [ ] Bug fix [ ] New feature [ ] Other, please explain:
What changes did you make? (Give an overview) replaced simple-get with fetch ponyfill, which polyfills fetch only on node Which issue (if any) does this pull request address? https://github.com/webtorrent/webtorrent/issues/2445 Is there anything you'd like reviewers to focus on? imports undici, for the socks agent, which I have mixed feelings on, maybe instead the socks agent should be provided by the users, same as http and https agent?