webtorrent / bittorrent-tracker

🌊 Simple, robust, BitTorrent tracker (client & server) implementation
https://webtorrent.io
MIT License
1.73k stars 315 forks source link

BREAKING CHANGE: drop simple-get #443

Closed ThaUnknown closed 8 months ago

ThaUnknown commented 1 year ago

What is the purpose of this pull request? (put an "X" next to item)

[ ] Documentation update [ ] Bug fix [ ] New feature [ ] Other, please explain:

What changes did you make? (Give an overview) replaced simple-get with fetch ponyfill, which polyfills fetch only on node Which issue (if any) does this pull request address? https://github.com/webtorrent/webtorrent/issues/2445 Is there anything you'd like reviewers to focus on? imports undici, for the socks agent, which I have mixed feelings on, maybe instead the socks agent should be provided by the users, same as http and https agent?

github-actions[bot] commented 1 year ago

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

ThaUnknown commented 1 year ago

this was abandoned, as native fetch doesn't have an agent parameter unlike node-fetch

socket-security[bot] commented 1 year ago

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

socket-security[bot] commented 10 months ago

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Packages Version New capabilities Transitives Size Publisher
undici 5.27.0 network, environment +1 1.22 MB ronag

🚮 Removed packages: simple-get@4.0.1

ThaUnknown commented 10 months ago

this now works, but imports undici, for the socks agent, which I have mixed feelings on, maybe instead the socks agent should be provided by the users, same as http and https agent?

webtorrent-bot commented 8 months ago

:tada: This PR is included in version 11.0.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket: